fix(core): assertoor sometimes fail in the blob transaction check #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The amount of lines of code in the project has not changed. |
|
The amount of lines of code in the project has not changed. |
|
The amount of lines of code in the project has not changed. |
|
The amount of lines of code in the project has not changed. |
mpaulucci
reviewed
Jan 10, 2025
|
The amount of lines of code in the project has not changed. |
|
Total lines added: 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are having a flaky test that most of the times affect other nodes instead of us in the blob check
Description
After the version changes related to assertoor I wasn't able to see the issue again (6 test locally, 4+ in this PR). This, unfortunately, is not a proof of the issue disappearing, I'm going to check every time this PR has diff with main and we can merge it if it continues to show no flaky tests.
EDIT: After some more local runs i was still able to see the test failing, so the versioning wasn't the solution. We need to continue testing this further.